changeset 1330:322a6fa415e0

Fix buglet in nano-tetris demo - garbage in state structure caused crashes
author gthomas
date Fri, 24 Oct 2003 18:15:52 +0000
parents c687f86ab7a4
children 22c47e969126
files packages/services/gfx/mw/current/ChangeLog packages/services/gfx/mw/current/src/demos/nanox/ntetris.c
diffstat 2 files changed, 8 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/packages/services/gfx/mw/current/ChangeLog
+++ b/packages/services/gfx/mw/current/ChangeLog
@@ -1,3 +1,9 @@
+2003-10-24  Gary Thomas  <gary@mlbassoc.com>
+
+	* src/demos/nanox/ntetris.c (main): Start with a good known
+	state (by zeroing) - otherwise, the results are unpredictable
+	and often crash.
+
 2003-09-03  Gary Thomas  <gary@mlbassoc.com>
 
 	* src/ecos/nanox_thread.c (nanox_thread): Fill in program
--- a/packages/services/gfx/mw/current/src/demos/nanox/ntetris.c
+++ b/packages/services/gfx/mw/current/src/demos/nanox/ntetris.c
@@ -430,7 +430,7 @@ static void block_reached_bottom(nstate 
 			state->level++;
 		draw_score(state);
 		y++;
-		nr:
+        nr: ;
 	}
 
 	choose_new_shape(state);
@@ -700,7 +700,6 @@ static int random8(int limit)
 
 static void choose_new_shape(nstate *state)
 {
-    diag_printf("%s - state: %x\n", __FUNCTION__, state);
 	state->current_shape.type = state->next_shape.type;
 	state->current_shape.orientation = state->next_shape.orientation;
 	state->current_shape.colour = state->next_shape.colour;
@@ -975,7 +974,7 @@ int main(int argc, char *argv[])
 {
 	nstate *state = my_malloc(sizeof(nstate));
 
-        printf("state = %x\n", state);
+        bzero(state, sizeof(*state));
 	init_game(state);
 	main_game_loop(state);